Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Russian localization Settings Window #1799

Merged
merged 6 commits into from
Jun 12, 2023
Merged

Russian localization Settings Window #1799

merged 6 commits into from
Jun 12, 2023

Conversation

dosymep
Copy link
Member

@dosymep dosymep commented Apr 14, 2023 •
edited
Loading

I have added localization for Settings Window.

@jmcouffin
Copy link
Contributor

Nice one
@eirannejad Do you see something in particular that would mess something else?
If not, we shall merge it.
After that I can add the french version eventually

@jmcouffin jmcouffin requested a review from eirannejad April 14, 2023 14:59
@jmcouffin jmcouffin added Prioritize The issue is planned to be resolved in the next version Localization Issues related to pyRevit localization [subsystem] labels Apr 14, 2023
@dosymep
Copy link
Member Author

dosymep commented Apr 15, 2023

Nice one @eirannejad Do you see something in particular that would mess something else? If not, we shall merge it. After that I can add the french version eventually

I think need test in others engines, I have tested in IronPython 2.7.

@dosymep
Copy link
Member Author

dosymep commented Apr 15, 2023

I think I will gradually translate, as this is a difficult task, plus there will be updates for the new revit, and there may be merge conflicts.

I think I will do the translation of windows in different Pull Requests.

@dosymep
Copy link
Member Author

dosymep commented Apr 15, 2023

in a good way, you need to write a utility that would receive all window translations and compare translation identifiers

@eirannejad eirannejad self-assigned this Jun 12, 2023
@eirannejad eirannejad changed the base branch from develop to pr/1799 June 12, 2023 06:34
@eirannejad eirannejad merged commit 759d738 into pyrevitlabs:pr/1799 Jun 12, 2023
@eirannejad
Copy link
Collaborator

Merged into develop and will be released with next version very soon. Thanks @dosymep @jmcouffin

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0849-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0858-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0910-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0908-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1046-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1150-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1153-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23164+0946-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23165+1014-wip

@dosymep dosymep deleted the localization/russian branch June 15, 2023 06:13
@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23166+0843-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+0833-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+1018-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+1041-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23177+1038-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23181+1652-wip

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

📦 New public release are available for 4.8.13.23182+2215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirannejad eirannejad Awaiting requested review from eirannejad

Assignees

@eirannejad eirannejad

Labels
Localization Issues related to pyRevit localization [subsystem] Prioritize The issue is planned to be resolved in the next version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dosymep @jmcouffin @eirannejad