Modification to Import/Export Family Configs #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # bin/pyrevit-hosts.json
The original behavior would assume all parameters were not shared. This commit detects shared parameters, and if they exist, creates another file and uses it to import them into Revit.
… string. The yaml file assumes the Load Classification Type to be a string, so when using the original import button, the Load Classification in Revit would not populate. The export script attaches a string to the beginning of the Load Classification Type in the yaml file. When the import script comes across the notifier string, it imports the value as a Load Classification Type. A more general solution is necessary for other types of parameters that use a ElementId.
|
Please let me know if I need to make any changes. |
|
Merged into |
|
@msmith320 Ok I made a series of updates to this in the
Once ready I can merge this into develop |
|
@eirannejad Thanks for looking at the scripts. I commented a few adjustments in your commit. There was a naming issue with |
|
Ok great. This is already merged so would you mind sending a new PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original import and export family configs buttons did not account for shared parameters or parameters whose values were of type ElementId. The following scripts use the GUID of shared parameters and a specific string to keep track of the shared parameters and the Load Classification Type. The export button saves a txt file in addition to the yaml file with the same name and in the same directory. For import, make sure both the txt and yaml file are in the same directory.