Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Keynotes: Update Keynote #522

Closed
braab1 opened this issue Feb 11, 2019 · 8 comments
Closed

Manage Keynotes: Update Keynote #522

braab1 opened this issue Feb 11, 2019 · 8 comments
Labels
Benign Bug Bug that doesn't stop user from using the tool but it makes it inconvenient [class] Enhancement Enhancement request [class->Improved #{number}: {title}]

Comments

@braab1
Copy link

braab1 commented Feb 11, 2019

Manage Keynotes: when editing keynotes, finalizing the edit by selecting "update keynote" yields the following error message: "Record does not exist in table 'keynotes'." The edited keynote is not updated and is then locked for editing by my username, but I cannot go back and re-edit.

image

@alexdaversa
Copy link
Contributor

This seems to be a bug specifically in keynotes without a parent.

@eirannejad
Copy link
Collaborator

@alexdaversa How are you creating a keynote with no parent??

@alexdaversa
Copy link
Contributor

@eirannejad the keynotes were imported from a working keynote file used on a previous project. The import worked successfully, but editing keynotes without a parent resulted in the same error message as in the screenshot as above.

@eirannejad eirannejad added Enhancement Enhancement request [class->Improved #{number}: {title}] Not pyRevit Issue This is not a pyRevit issue. Might be related to environment, host app, or other dependencies. Benign Bug Bug that doesn't stop user from using the tool but it makes it inconvenient [class] and removed Not pyRevit Issue This is not a pyRevit issue. Might be related to environment, host app, or other dependencies. labels Feb 11, 2019
@alexdaversa
Copy link
Contributor

@eirannejad We worked around the issue by adding a parent to all keynotes manually before adding them to Revit using the Manage Keynotes tool--but wouldn't at least one keynote in the list not have a parent?

@eirannejad
Copy link
Collaborator

eirannejad commented Feb 12, 2019

@alexdaversa Any keynote with no parent is a Category. Move those to the @table(categories... table

@eirannejad
Copy link
Collaborator

Can not replicate the error using the import keynotes tool. The import assumes any keynote without a parent is actually a category and works fine.

The only explanation is that a special character is used for the keynote parent.

@alexdaversa
Copy link
Contributor

alexdaversa commented Feb 21, 2019

00_RevitKeynotes_Imperial_532_old.txt
This is the keynote file in question that caused the error message. I'm not suggesting that the plugin should be updated to deal with this sort of poorly formatted file--rather, we (me and braab1) should work from a known well-formatted base file to avoid these issues.

eirannejad added a commit that referenced this issue Feb 21, 2019
@eirannejad
Copy link
Collaborator

eirannejad commented Feb 21, 2019

@alexdaversa Okay thanks a lot for this. The issue was something else completely and I fixed it. The problem was the GUI would allow you to edit a category when in ALL CATEGORIES listing mode using the edit keynote button.

I'll push the changes this weekend.

eirannejad added a commit that referenced this issue Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benign Bug Bug that doesn't stop user from using the tool but it makes it inconvenient [class] Enhancement Enhancement request [class->Improved #{number}: {title}]
Projects
None yet
Development

No branches or pull requests

3 participants