Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: not able to save the js part of the output windows as html + js dependencies #1133

Closed
jmcouffin opened this issue Jan 21, 2021 · 1 comment
Labels
Benign Bug Bug that doesn't stop user from using the tool but it makes it inconvenient [class] Prioritize The issue is planned to be resolved in the next version

Comments

@jmcouffin
Copy link
Contributor

Describe the bug
When using preflight to generate the report we use the chart.js module to print doughnut charts in the output window. When using the save button of the window, it saves it as html but does not take into account the chart part.

To Reproduce
Steps to reproduce the behavior:

  1. run preflight checks
  2. Click on 'save' in the output window
  3. Open the saved file in chrome
  4. no js charts displaying

Expected behavior
saving the full content of the output window

Screenshots
missing chart in yellow
image

Desktop (please complete the following information):

  • develop branch
@eirannejad
Copy link
Collaborator

eirannejad commented Jan 21, 2021

Huh! Seems like the combination of defer and async are causing issues. Removing them runs the chart code properly. I'll fix this

<script src="https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.8.0/Chart.min.js" defer="" async="true"></script>

@eirannejad eirannejad added Benign Bug Bug that doesn't stop user from using the tool but it makes it inconvenient [class] Prioritize The issue is planned to be resolved in the next version labels Jan 21, 2021
eirannejad added a commit that referenced this issue Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benign Bug Bug that doesn't stop user from using the tool but it makes it inconvenient [class] Prioritize The issue is planned to be resolved in the next version
Projects
None yet
Development

No branches or pull requests

2 participants