Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer test script #17

Merged
merged 2 commits into from
Oct 22, 2015
Merged

Add composer test script #17

merged 2 commits into from
Oct 22, 2015

Conversation

DominicImhof
Copy link

No description provided.

@pyrech
Copy link
Owner

pyrech commented Oct 21, 2015

Hi,
Thank you for this PR but I'm not sure to understand what are the advantages of a test script?

@MaxGfeller
Copy link
Contributor

+1 for this.

Composer supports defining custom scripts. Major PHP projects started adapting this and are now all defining their own test scripts. Here are some examples:

https://github.com/composer/composer/blob/master/composer.json#L63-L65
https://github.com/Seldaek/monolog/blob/master/composer.json#L60-L63

The advantage of this is pretty obvious; you don't have to have a global phpunit/whatever setup and can just run composer test for each library that you want to start working with.

I have written an article about this a while ago, if it interests you.

@paulmallet
Copy link

👍

@pyrech
Copy link
Owner

pyrech commented Oct 22, 2015

Thank you for your explanations @MaxGfeller. If this is becoming the standard, let's merge it. :)
Thank you @DominicImhof for your PR.

pyrech added a commit that referenced this pull request Oct 22, 2015
@pyrech pyrech merged commit da3ba85 into pyrech:master Oct 22, 2015
@MaxGfeller
Copy link
Contributor

Awesome, thank you @pyrech and @DominicImhof! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants