Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dc_type to dc_types #1013

Merged
merged 2 commits into from
Apr 30, 2024
Merged

dc_type to dc_types #1013

merged 2 commits into from
Apr 30, 2024

Conversation

finozzifa
Copy link
Contributor

@finozzifa finozzifa commented Apr 30, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@ekatef
Copy link
Member

ekatef commented Apr 30, 2024

Great @finozzifa! Let's wait until CI is successful and ready to merge after :)

@davide-f
Copy link
Member

Interesting; I'm wondering why these issues were not captured by the CI.
It may be useful to update the CI to avoid these issues in the future

@ekatef
Copy link
Member

ekatef commented Apr 30, 2024

Interesting; I'm wondering why these issues were not captured by the CI. It may be useful to update the CI to avoid these issues in the future

Absolutely agree :) I'd merge this PR and open an issue to track CI advancements. Would you agree?

@davide-f
Copy link
Member

Ok :)

@ekatef ekatef merged commit edb2fce into pypsa-meets-earth:main Apr 30, 2024
5 checks passed
@ekatef
Copy link
Member

ekatef commented Apr 30, 2024

Thanks a lot @finozzifa! Merged :)

Have opened #1016 to track CI coverage. Feel free to investigate it, if you can be interested.

@finozzifa
Copy link
Contributor Author

I will be happy to once I am done with #501 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants