Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmented line connections bug fix #1011

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Augmented line connections bug fix #1011

merged 5 commits into from
Apr 29, 2024

Conversation

finozzifa
Copy link
Contributor

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • [ x] I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • [x ] I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • [x ] A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

doc/release_notes.rst Outdated Show resolved Hide resolved
@ekatef
Copy link
Member

ekatef commented Apr 29, 2024

Hello @finozzifa!

Thanks for the contribution :D Have added a little comment which relates to making the release note look nice.

Otherwise, looks good for me :)

@finozzifa
Copy link
Contributor Author

finozzifa commented Apr 29, 2024

Hi @ekatef, I performed the changes you requested. I hope I got your message right? if not, let me know :)

@ekatef
Copy link
Member

ekatef commented Apr 29, 2024

Hi @ekatef, I performed the changes you requested. I hope I got your message right? if not, let me know :)

Perfect, thanks a lot for the changes!!

Let's wait until CI will run. After that, ready to be merged I think, unless @davide-f has any additional comments 🙂

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Ci passes, it looks good to me :)
Feel free to merge :)

@ekatef ekatef merged commit 3f3a32f into pypsa-meets-earth:main Apr 29, 2024
5 checks passed
@ekatef
Copy link
Member

ekatef commented Apr 29, 2024

Merged :)
@finozzifa thanks a lot for the fix and welcome into the contributors list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants