-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warehouse: Remove <form> on WebAuth provision #6546
Conversation
Add a keyevent for the label input.
Is it possible to use |
I was under the impression that the CSP policy would block it, based on this
But I'll give it a try locally! |
Yep, I get a CSP error when activating the form via |
Why do we need the new JS here? Can we just revert adding the |
The JS handles the case where the user hits the return key on the label input. With I could remove it and limit this PR to just the revert, but I think the non- |
Will revisit in a future PR.
<form>
was introduced in #6524, but was causing some weird routing when submitted via the return key rather than a direct button press (probably because<form>
defaults toGET
). It's also unfortunately still nonfunctional withmethod="POST"
, since we still need to perform the relevant WebAuthn operations in JavaScript.