Improve owner/maintainer documentation #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
reviewed
Mar 19, 2018
| @@ -23,10 +23,10 @@ <h2>Collaborators</h2> | |||
| <div class="callout-block"> | |||
| <p>There are two possible roles for collaborators:</p> | |||
| <dl> | |||
| <dt>Maintainer</dt> | |||
| <dd>May upload releases for a project. Cannot add collaborators, delete files, delete releases or delete the project.</dd> | |||
| <dt>Owner</dt> | |||
| <dd>Owns a package, may add other collaborators for that package, and upload releases for a package.</dd> | |||
There was a problem hiding this comment.
While you're here, could you update this line to indicate that owners can delete releases and can delete the project?
|
Ok, I edited the text a little. Replaced all may's with can's. Also, while reading closely I thought it to be preferable to reorder the order of ideas. Do you think it looks good? One thing I am wondering is if I ought to delete the reference to
|
|
@jmuzsik I think deleting the "Owns a package" is fine, it's a bit redundant anyways 🙂 |
di
approved these changes
Mar 19, 2018
|
Thanks @jmuzsik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, simple fix, only had to move some lines around/add text. Thanks!