test: add types to oidc.* modules #18798
Merged
+295
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
force-pushed
the
miketheman/oidc-types
branch
from
82d80fc to
ad628c1
Compare
|
Almost ready, there's some more precision to add in |
Starting with `warehouse.oidc.interfaces`, apply hints where necessary, and correct a few unchecked definitions. Further commits will add more types to OIDC-related code to increase safety and minimize errors while changing. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Working down the OIDC stack, adding hints to the services and utils modules. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/oidc-types
branch
from
e07f9ab to
1d1ecf2
Compare
di
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase safety when working with these complex modules, while learning how they interoperate.
Precision (aka coverage) of
warehouse.oidc:Measurement done via
python -m mypy --html-report htmlcov -p warehouse.oidcand inspecting the generated output.Lower imprecision == fewer ambiguities == good thing
Higher LOC == more lines covered == good thing