perf: speed up user profile page #17269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From a local dev, largest user is OCA (similar to prod), with only 193 projects, the results are demonstrative. Before: After: |
miketheman
force-pushed
the
miketheman/query-improvement
branch
from
a63e54a to
1e30096
Compare
For users with a large amount of projects, the template iteration through `projects` to fetch their latest `release` details turns into an n+1 query, and can time out on larger user profile pages. Refactor the query to perform most of the logic to fetch only the data necessary to render the template correctly, removing the need to load full entities. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/query-improvement
branch
from
1e30096 to
058d716
Compare
ewdurbin
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users with a large amount of projects, the template iteration through
projectsto fetch their latestreleasedetails turns into an n+1query, and can time out on larger user profile pages.
Refactor the query to perform most of the logic to fetch only the data
necessary to render the template correctly, removing the need to load
full entities.
Signed-off-by: Mike Fiedler miketheman@gmail.com