docs: move integration guide to user-docs #17173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
di
reviewed
Nov 25, 2024
ewdurbin
approved these changes
Nov 26, 2024
Signed-off-by: William Woodruff <william@trailofbits.com>
di
approved these changes
Nov 26, 2024
woodruffw
commented
Nov 26, 2024
| # https://www.python.org/dev/peps/pep-0491/#file-name-convention | ||
| wheel_parts = { | ||
| tag: re.sub(r'[^\w\d.]+', '_', part, re.UNICODE) | ||
| for tag, part in locals().items() |
There was a problem hiding this comment.
I had never noticed this before, but this example function is pretty wonky -- it uses locals() for building the wheel_parts here, which is both brittle and probably harder than necessary for more junior Python devs to follow.
I can do a follow-up PR to refactor it if there's interest, or maybe find an alternative implementation of it elsewhere.
There was a problem hiding this comment.
I'm currently working on an improvement to pypa/packaging which should simplify this, so totally fine to leave this as is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #16541.
This is mostly a straight inclusion of
integration-guide.rst, although I've added some links to the PyPI where previously only the PyPI mailing list was noted (for announcements).