oidc: move reusable_worfklow_used field to the correct event #16935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
commented
Oct 21, 2024
miketheman
reviewed
Oct 21, 2024
Signed-off-by: William Woodruff <william@trailofbits.com>
|
also LGTM |
miketheman
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the
reusable_workflow_useddata quality issues we're seeing, which stem from us originally trying to get it atfile_uploadtime, where the request has only a limited view into the original minted token's OIDC claims.We instead now collect this field during
mint_token, where the full set of OIDC claims is available to us.h/t @miketheman for pointing this out, cc @facutuesca