Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: capture metrics during email validation #16739

Merged

Conversation

miketheman
Copy link
Member

Includes changes to enable request.metrics.increment(...) and coverage output.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Since the HTML report has the ability to skip covered files selectively,
we can leave that up to the reader, and give them the full context.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman requested a review from a team as a code owner September 18, 2024 14:42
@miketheman miketheman force-pushed the miketheman/track-registration-outcomes branch from 2e34c4b to 9d1c27a Compare September 18, 2024 14:52
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman force-pushed the miketheman/track-registration-outcomes branch from 9d1c27a to 7f9232b Compare September 18, 2024 14:59
@miketheman miketheman enabled auto-merge (squash) September 18, 2024 15:05
@miketheman miketheman merged commit 001165f into pypi:main Sep 18, 2024
18 checks passed
@miketheman miketheman deleted the miketheman/track-registration-outcomes branch September 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants