chore: strip out whitespace added by jinja blocks #14709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking at source of HTML, we emit whitespace around Jinja blocks. While individual blocks can opt out of emitting this whitespace with `-` control characters (like `robots.txt` did), it is simpler to apply this as a global setting. On pages like `/help/`, these settings remove some 500 lines of whitespace from the output. Refs: https://jinja.palletsprojects.com/en/3.0.x/templates/#whitespace-control Signed-off-by: Mike Fiedler <miketheman@gmail.com>
ewdurbin
approved these changes
Oct 10, 2023
|
FYI, looks like this is causing some missing spaces in places where we previously expected newlines to get converted to whitespace: 
This example is from https://github.com/pypi/warehouse/blob/b2a306fbc6e1087d484f422863b31d569cf09d8b/warehouse/templates/packaging/detail.html#L382C1-L383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at source of HTML, we emit whitespace around Jinja blocks.
While individual blocks can opt out of emitting this whitespace with
-control characters (likerobots.txtdid), it is simpler to apply this as a global setting.On pages like
/help/, these settings remove some 500 lines of whitespace from the output.Refs: https://jinja.palletsprojects.com/en/3.0.x/templates/#whitespace-control