Replace reference to setup.py in settings with pyproject.toml #11985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
reviewed
Aug 8, 2022
| @@ -102,7 +102,7 @@ <h3>{% trans %}<abbr title="two factor authentication">2FA</abbr> requirement{% | |||
| <h3>{% trans %}Project description and sidebar{% endtrans %}</h3> | |||
| <p> | |||
| {% trans trimmed project_name=project.name, setup_args_href='https://packaging.python.org/tutorials/distributing-packages/#setup-args', twine_docs_href='https://twine.readthedocs.io/en/latest/', distribution_href='https://packaging.python.org/tutorials/distributing-packages/' %} | |||
There was a problem hiding this comment.
We should probably also update the setup_args_href link to have a different name and point to https://packaging.python.org/en/latest/tutorials/packaging-projects/#creating-pyproject-toml or something similar instead.
|
@JakobDev, any plans to resolve the issues here or should we close this? |
miketheman
added
the
awaiting-response
|
I made #13143 to capture the overall issue here. |
Closed
sabre-code
added a commit
to sabre-code/warehouse
that referenced
this pull request
Mar 27, 2023
Addressed issue mentioned in this comment here pypi#11985 (comment) @miketheman Please check if it's exactly the way you suggested. Thanks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a setup.py is outdated. Even the linked tutorial already uses a pyproject.toml.