-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-duplicate "Owner" and "Maintainer" roles #2745
Comments
I think I'm unclear -- what can an Owner do that a Maintainer can't do? I am probably going to open a documentation issue to put that info somewhere users can get at. Thanks. |
@brainwane The following information box is included on the 'Collaboration' page where a user has the ability to change these roles: I think that should probably suffice in terms of documentation, but it probably wouldn't hurt to duplicate it elsewhere. |
Actually, this should probably get revised, because Owners can do other things too now (like delete files, releases, and the entire project). |
This was causing the 503 error experienced in #4728, seen here: https://sentry.io/python-software-foundation/warehouse-production/issues/677429114/ |
* Roles: db migration to create constraints Fixes #2745 * lint * do it correctly * Fix a flakey test and its brethren * One stinkin' line fix * Update translations * fix broken test, no need for a dyanmic value to exercise invalid key * fix role_id hidden input * fixup signature of get_user_role_in_project * update translations * lint... Co-authored-by: Donald Stufft <donald@stufft.io> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Currently on pypi-legacy, it's possible for a user to have both the "Owner" and "Maintainer" roles.
However, an "Owner" can do everything a "Maintainer" can do, so it doesn't make sense for a user to be able to have both roles.
In the short term, we decided to add a hack to hide any "duplicate" roles in #2705, and remove the ability to add multiple roles for the same user in Warehouse.
Once pypi-legacy is shut down, we can run a migration which removes any of these "duplicate" roles., and remove this hack.
The text was updated successfully, but these errors were encountered: