Split out this setup.py fix from https://github.com/pypa/virtualenv/pull/635

[shidesthewise]

Fix default args for py.test to be "tests" instead of using the
command name "test" also as the directory name to find tests.

[pfmoore]

I'm somewhat baffled by this, as I thought py.test should discover the tests directory automatically when run without arguments. It does when I run it from the command line.

I guess the problem is a setup.py test peculiarity so I'm going to say I'm fine with this change but I'd prefer someone with experience with the setuptools test command to review and commit it.

[Ivoz]

Will do when I get myself back on nix

[shidesthewise]

I think I had tracked it down to a _pytest/config.py, _preparseconfig. Someone better versed in this area should definitely double-check my assumptions on how this was working.

def _prepareconfig(args=None, plugins=None):
    if args is None:
        args = sys.argv[1:]

sys.argv[1:] == ['test'] when going through setup.py test

[Ivoz]

Hmm, then perhaps this is an issue with pytest's example, pytest_args should be set to [], not None.

[shidesthewise]

I was wondering what the likelihood of these being adopted and merged into the mainline.

[pfmoore]

See http://pytest.org/latest/goodpractises.html#integration-with-setuptools-test-commands - should this not be self.pytest_args = []?

Having said this, the tests for virtualenv are a bit of a mess and don't really follow the py.test standard discovery rules - see http://pytest.org/latest/goodpractises.html#test-discovery

I'd rather we fixed up the tests properly instead of hard-coding a tests directory that could cause us grief later...

[shidesthewise]

Because this is old and based on 1.11 and virtualenv is now in a 13.X series, I'll re-submit.