Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid showing new windows on Windows #1929

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Avoid showing new windows on Windows #1929

merged 1 commit into from
Aug 31, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Aug 24, 2020

Resolves #1928.

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #1929 into master will decrease coverage by 8.82%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1929      +/-   ##
==========================================
- Coverage   93.96%   85.13%   -8.83%     
==========================================
  Files          86       86              
  Lines        4225     4225              
==========================================
- Hits         3970     3597     -373     
- Misses        255      628     +373     
Flag Coverage Δ
#tests 85.13% <66.66%> (-8.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/seed/wheels/periodic_update.py 98.56% <50.00%> (-0.48%) ⬇️
src/virtualenv/util/subprocess/__init__.py 88.88% <100.00%> (-11.12%) ⬇️
src/virtualenv/discovery/windows/pep514.py 0.00% <0.00%> (-100.00%) ⬇️
src/virtualenv/discovery/windows/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
src/virtualenv/util/subprocess/_win_subprocess.py 0.00% <0.00%> (-95.09%) ⬇️
src/virtualenv/util/path/_pathlib/via_os_path.py 0.00% <0.00%> (-91.51%) ⬇️
src/virtualenv/create/via_global_ref/store.py 50.00% <0.00%> (-40.00%) ⬇️
src/virtualenv/activation/batch/__init__.py 66.66% <0.00%> (-33.34%) ⬇️
.../create/via_global_ref/builtin/cpython/cpython3.py 67.39% <0.00%> (-28.27%) ⬇️
src/virtualenv/info.py 77.50% <0.00%> (-22.50%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c098d8...380c2b5. Read the comment docs.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@pradyunsg
Copy link
Member

@gaborbernat Anything blocking the merge on this?

@gaborbernat gaborbernat merged commit dc5eb79 into master Aug 31, 2020
@gaborbernat gaborbernat deleted the fix/1818 branch August 31, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several cmd.exe windows spawned when running virtualenv on Windows
4 participants