Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite the documentation #1519

Merged
merged 2 commits into from
Feb 4, 2020
Merged

rewrite the documentation #1519

merged 2 commits into from
Feb 4, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Jan 29, 2020 •
edited
Loading

Resolves #1465.

pradyunsg
pradyunsg reviewed Feb 1, 2020
View reviewed changes
LICENSE Outdated Show resolved Hide resolved
@pradyunsg
Copy link
Member

There seem to be a whole bunch of not-documentation changes here -- is that intentional?

@gaborbernat
Copy link
Contributor Author

@pradyunsg moved those out now to #1535, #1536 and #1534

@gaborbernat gaborbernat mentioned this pull request Feb 2, 2020
Closed
4 tasks
@gaborbernat
Copy link
Contributor Author

Done, documentation is now ready under https://external-builds.readthedocs.io/html/virtualenv/1519/index.html

This is now good enough for the first iteration, please feel free to comment, I'll merge later today with potential feedback.

@pypa pypa deleted a comment from pradyunsg Feb 4, 2020
pradyunsg
pradyunsg reviewed Feb 4, 2020
View reviewed changes
docs/_static/custom.css Outdated Show resolved Hide resolved
@gaborbernat
rewrite the documentation
6ce1721 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
compromise on 1080px
3c83c56 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
Copy link
Contributor Author

I'll merge so we can release the next beta, but we can do fixes in follow-up PRs.

@gaborbernat gaborbernat merged commit 7a5d03f into pypa:rewrite Feb 4, 2020
@gaborbernat gaborbernat deleted the doc branch February 4, 2020 14:51
@pradyunsg pradyunsg mentioned this pull request Feb 4, 2020
Merged
@adamchainz adamchainz mentioned this pull request Jan 17, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaborbernat @pradyunsg