Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use intersphinx for requests links #1037

Merged
merged 1 commit into from
Dec 23, 2023
Merged

docs: use intersphinx for requests links #1037

merged 1 commit into from
Dec 23, 2023

Conversation

miketheman
Copy link
Member

We already have the mapping, take advantage of it.

@miketheman
Copy link
Member Author

Relies on SOCKS being added via psf/requests#6613

@miketheman miketheman marked this pull request as ready for review December 23, 2023 17:26
@miketheman
docs: use intersphinx for requests links
314d346 
We already have the mapping, take advantage of it.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman force-pushed the miketheman/use-intersphinx branch from f172b07 to 314d346 Compare December 23, 2023 17:28
@miketheman
Copy link
Member Author

Updated now socks exists, passes linkcheck. I expect it to fail on the integration check, which has been failing recently.

@sigmavirus24 sigmavirus24 merged commit b54af26 into pypa:main Dec 23, 2023
22 of 23 checks passed
@miketheman miketheman deleted the miketheman/use-intersphinx branch December 23, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigmavirus24 sigmavirus24 sigmavirus24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miketheman @sigmavirus24