-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings: remove old mypy workarounds #1029
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
Ah, this is a bit of a pain: the workaround is no longer needed on newer versions of |
Looks like this is the snarl: the version of Some options here:
|
We aren't deliberately trying to keep 3.7 alive, just like we aren't deliberately not testing on 3.11 or 3.12,so I think we can drop 3.7 |
Sounds good. I can drop 3.7 and add 3.{11,12} in this PR. |
Also adds 3.10 through 3.12, where missing. Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Docs error looks like a re-manifestation of #838:
|
Signed-off-by: William Woodruff <william@yossarian.net>
# Remove this upper bound when twine's minimum Python is 3.9+. | ||
# See: https://github.com/sphinx-doc/sphinx/issues/11767 | ||
Sphinx>=6,<7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: This is my temporary hack for working around sphinx-doc/sphinx#11767.
Another option here would be to do the docs build in CI on Python 3.9 or newer, since those don't seem to be affected. But I wasn't sure if tox -e docs
was expected to work on all supported Python versions or not 🙂
The last lingering failure here is in the integration suite; TestPyPI is returning 503s. That doesn't look localized to this PR, so I think that will just need to wait (or be ignored) 🙂 |
Odd I could have sworn we were using devpi for a server local to that test |
Looks like there's |
Another oddity: TestPyPI returned 503, but the dist is present: https://test.pypi.org/project/twine-sampleproject/3.0.0.post20231123223830060228/ |
Very odd. I think I'm going to merge this despite that |
Ah, guess I can't force merge this. |
Post-hoc triage: the 503 in the integration tests here was caused by pypi/warehouse#14928. I'll fix that. |
These workarounds are no longer necessary on recent versions of
mypy
, and are causing CI failures (due to redundant casts).