Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #4849

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented Feb 22, 2025

Summary of changes

I reviewed the TODO comments and attempted to address some of them.

Additionally, I found some typos during this process. Perhaps the setuptools project could introduce spellcheck hooks in .pre-commit-config.py to catch and fix more typos automatically.

Pull Request Checklist

- [ ] Changes have tests

@shenxianpeng shenxianpeng force-pushed the review-todo-and-fix-typos branch from 4838f33 to c1f2daa Compare February 22, 2025 14:21
@Avasam
Copy link
Contributor

Avasam commented Feb 23, 2025

introduce spellcheck hooks in .pre-commit-config.py to catch and fix more typos automatically

I doubt the signal-to-noise ratio would be worth it. Having random spellcheck passes once in a while like you did is probably enough. But that's just my opinion.

@shenxianpeng shenxianpeng changed the title Fix TODOs and typos Fix typos Feb 23, 2025
Copy link
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @shenxianpeng.

Some of these are not strictly typos (just a different orthography due to differences between English speaking countries), but it should be fine to convert between them.

(In terms of potential follow ups for actions/pre-commit hooks, I would avoid being too restrictive in terms of what we accept from contributors, e.g. people should feel welcome to contribute using the way they right English in their countries regardless if they come from Europe/Oceania/Africa/America etc...).

Could you please have avoid submitting changes to the _vendor and or _distutils repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants