Fix formatting and imports for Python 3.9 #4729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/CC @abravalheri |
abravalheri
force-pushed
the
fix-tests
branch
from
a608158 to
a572416
Compare
abravalheri
reviewed
Nov 4, 2024
| if sys.version_info < (3, 9): | ||
| import importlib_resources as resources # pragma: no cover | ||
| else: | ||
| import importlib.resources as resources # noqa: F401 |
There was a problem hiding this comment.
I think that if we don't do this change, we might be able to keep the PRs thematically separated... let me see if we can do that.
|
Thank you, I have manually merged this one with some changes: 7a298d9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Small PR to fix CI tests.