Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pypa/distutils #4649

Merged
merged 31 commits into from
Sep 15, 2024
Merged

Merge pypa/distutils #4649

merged 31 commits into from
Sep 15, 2024

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Sep 15, 2024 •
edited
Loading

  • Ignore TRY400 globally
  • Clean up ruff ignore
  • Clean up cruft in errors docstring.
  • Rely on dependencies instead of vendoring them.
  • Simply log the directory being created, rather than the whole ancestry.
  • Updated mkpath to use pathlib.Path.mkdir.
  • Refactored mkpath as a singledispatch function.
  • Replaced global variable with a custom cache wrapper.
  • Extracted _copy_one function.
  • "Removed support for 'compress="compress"' to archive_util.make_tarball."
  • Removed deprecated 'check_warnings' from 'sdist' and 'regitser' commands.
  • Enabled TestPyPIRCCommand to run its tests.
  • Removed dependence of TestSdist on test_config.
  • Replaced open/read/close logic with 'read_text' and added encoding to address EncodingWarning.
  • Remove collect_ignore referring to msvc9compiler.
  • Flagged register and upload commands and deprecated.
  • Decouple sdist tests from pypirc fixture.
  • Removed PyPI commands (register, upload) and supporting logic.
  • Remove borland compiler.
  • cygwinccompiler: Get the compilers from sysconfig
  • Fix cross-platform compilation using distutils._msvccompiler.MSVCCompiler Actually use the plat_name param in MSVCCompiler.initialize Added tests
  • Move the comment to the docstring.
  • Use double-backticks for rst compatibility.
  • Remove news fragments, not useful here.

Summary of changes

Closes

Pull Request Checklist

DimitriPapadopoulos and others added 30 commits September 4, 2024 09:12
@DimitriPapadopoulos
Ignore TRY400 globally
340137f 
While the suggestion might be valid in some cases, it doesn't fit all
use cases and ends up being a nuisance.
@DimitriPapadopoulos
Clean up ruff ignore
aba9eef
@jaraco
Clean up cruft in errors docstring.
8e8f0cb
@jaraco
Rely on dependencies instead of vendoring them.
cded66c
@jaraco
Simply log the directory being created, rather than the whole ancestry.
10078fe
@jaraco
Updated mkpath to use pathlib.Path.mkdir.
45b1295
@jaraco
Refactored mkpath as a singledispatch function.
284279d
@jaraco
Replaced global variable with a custom cache wrapper.
f2157f5
@jaraco
Extracted _copy_one function.
e2ab601
@jaraco
"Removed support for 'compress="compress"' to archive_util.make_tarba…
bcba955 
…ll."
@jaraco
Removed deprecated 'check_warnings' from 'sdist' and 'regitser' comma…
3d38185 
…nds.
@jaraco
Merge pull request pypa/distutils#293 from DimitriPapadopoulos/TRY400
fa578e7 
Ignore TRY400 globally
@jaraco
Enabled TestPyPIRCCommand to run its tests.
05668ed
@jaraco
Removed dependence of TestSdist on test_config.
eebb121
@jaraco
Replaced open/read/close logic with 'read_text' and added encoding to…
dc7e309 
… address EncodingWarning.
@jaraco
Remove collect_ignore referring to msvc9compiler.
c2c1f32
@jaraco
Flagged register and upload commands and deprecated.
ddc1555
@jaraco
Decouple sdist tests from pypirc fixture.
6ce5426
@jaraco
Removed PyPI commands (register, upload) and supporting logic.
2e6f25c
@jaraco
Merge pull request pypa/distutils#294 from pypa/debt/pypi-commands
4852078 
Removed PyPI commands (register, upload) and supporting logic.
@jaraco
Remove borland compiler.
bddd259
@naveen521kk
cygwinccompiler: Get the compilers from sysconfig
4ecf617 
On the CLANG64 environment of MSYS2, we should use clang
instead of gcc. This patch gets the compiler from sysconfig which
would be set when Python was built.

Without this patch, the build fails when it's trying to check if the
compiler is cygwin's one.
@jaraco
Merge https://github.com/jaraco/skeleton
3ac1adc
@Avasam
Fix cross-platform compilation using `distutils._msvccompiler.MSVCCom…
a0339c1 
…piler`

Actually use the `plat_name` param in `MSVCCompiler.initialize`
Added tests
@jaraco
Move the comment to the docstring.
d38d1a3
@jaraco
Use double-backticks for rst compatibility.
f15beb8
@jaraco
Fix cross-platform compilation using `distutils._msvccompiler.MSVCCom…
47353c5 
…piler`

Merge pull request pypa/distutils#298 from Avasam/MSVCCompiler-cross-platform-bug
@jaraco
cygwinccompiler: Get the compilers from sysconfig
7283751 
Merge pull request pypa/distutils#296 from msys2-contrib/clang-compilers
@jaraco
Remove news fragments, not useful here.
378984e
@jaraco
Merge https://github.com/pypa/distutils into feature/distutils-7283751
ce01828
@jaraco jaraco marked this pull request as ready for review September 15, 2024 14:57
@jaraco jaraco merged commit af9e245 into main Sep 15, 2024
46 checks passed
@jaraco jaraco deleted the feature/distutils-7283751 branch September 15, 2024 15:31
@abravalheri abravalheri mentioned this pull request Sep 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaraco @DimitriPapadopoulos @naveen521kk @Avasam