change VERSION to __version__ in the example #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Aug 22, 2024
webknjaz
approved these changes
Aug 22, 2024
abravalheri
reviewed
Aug 23, 2024
change string, list or tuple to "string" -- in the footnote about attr -- it is only referenced by dynamic version -- and the version should only be a string (PEP 440).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
In the example for dynamic specifying a version from a package attribute, change
VERSIONto__version__.__version__is the most common convention, I think it's better to have the example reflect that.See the discussion in:
pypa/packaging.python.org#1580
and many other discussions --