Ruff: enable all pyflakes and perf rules #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
ruff-all-pyflakes-and-perf-rules
branch
2 times, most recently
from
1f341a8
to
ca0f6c7
Compare
Avasam
force-pushed
the
ruff-all-pyflakes-and-perf-rules
branch
2 times, most recently
from
22a9da2
to
5345768
Compare
Avasam
force-pushed
the
ruff-all-pyflakes-and-perf-rules
branch
from
5345768
to
5aed410
Compare
Avasam
force-pushed
the
ruff-all-pyflakes-and-perf-rules
branch
from
5aed410
to
acf10fd
Compare
Avasam
force-pushed
the
ruff-all-pyflakes-and-perf-rules
branch
from
acf10fd
to
1f4b082
Compare
Avasam
force-pushed
the
ruff-all-pyflakes-and-perf-rules
branch
from
1f4b082
to
01c7ce4
Compare
|
It's been a couple PRs where the PyPy test gets randomly cancelled, that's weird |
abravalheri
approved these changes
Oct 21, 2024
| @@ -2187,7 +2187,7 @@ def get_args(cls, dist, header=None): | |||
| spec = str(dist.as_requirement()) | |||
| for type_ in 'console', 'gui': | |||
| group = type_ + '_scripts' | |||
| for name, ep in dist.get_entry_map(group).items(): | |||
| for name in dist.get_entry_map(group).keys(): | |||
There was a problem hiding this comment.
If we are not using the values, then we can just iterate over the original object no? There would be no reason to call .keys(), right?
There was a problem hiding this comment.
yeah iterating over a dict should be the same as iterating over its keys since we don't do anything special with the view-object. I kept it consistent with other places in code. (this might be an opiniated preference)
Avasam
force-pushed
the
ruff-all-pyflakes-and-perf-rules
branch
from
cccadd2
to
d771884
Compare
|
Thank you @Avasam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Setuptools conforms to all the Ruff-implemented Pyflakes and Perflint rules except
PERF203and a single instance ofPERF102. So we can be less picky about their selection.PERF203is worth looking at, but is often a micro-optimisation with false-positives, let's not block the CI on that. I applied it on some tests.Pull Request Checklist
newsfragments/. (no public-facing change)(See documentation for details)