Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with distutils@d7ffdb9c7 #4538

Closed
wants to merge 62 commits into from
Closed

Commits on Mar 2, 2024

  1. Configuration menu
    Copy the full SHA
    2c93711 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    26f4723 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fbac766 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9f176ac View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5174927 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Configuration menu
    Copy the full SHA
    fa6e218 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45a232a View commit details
    Browse the repository at this point in the history
  3. For consistency, ensure Extension.sources is always a pathlib.Path ob…

    …ject and adjust expectations in tests.
    jaraco committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    9cc0c93 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c489cdc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f2a85c1 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Merge pull request #239 from DimitriPapadopoulos/extra_pairs_of_quotes

    Remove extra quotes from litteral strings
    jaraco committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    53c82a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45740e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    3048e1b View commit details
    Browse the repository at this point in the history
  2. Revert "Disable cygwin tests for now. Ref #3921"

    This reverts commit d3e5de0.
    jaraco committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1bcd839 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. find_library_file: port from doctest to normal test and fix for cygwin

    Starting with b42197c UnixCCompiler got some improved support
    for cygwin which made the doctest fail.
    
    The doctest is hard to read as is, and adding more platform specific exceptions
    wouldn't help, so just convert to a normal test and special case cygwin to make
    the test pass there again.
    lazka committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f21f19a View commit details
    Browse the repository at this point in the history
  2. test_customize_compiler_with_msvc_python: skip for cygwin

    Mingw32CCompiler() checks that the default compiler isn't cygwin,
    so it can't be used under cygwin, so skip it there.
    lazka committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7d78834 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge pull request #270 from msys2-contrib/fix-cygwin-ci

    Fix cygwin CI job
    jaraco committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    683df4e View commit details
    Browse the repository at this point in the history
  2. Prefer f-strings

    jaraco committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    813ab98 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Configuration menu
    Copy the full SHA
    76e1e71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e27b973 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    58afb01 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    848c48b View commit details
    Browse the repository at this point in the history
  5. 👹 Feed the hobgoblins (delint).

    Fix PERF401 errors.
    jaraco committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d6a581f View commit details
    Browse the repository at this point in the history
  6. Allow path objects

    InvincibleRMC authored and jaraco committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d3c76bb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    12f2ef0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8a9ca8b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    206ca2a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f7adff4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b440f45 View commit details
    Browse the repository at this point in the history
  12. Use explicit registration for compatibility with older Pythons.

    Prior to 3.11, singledispatch[method] doesn't know about unions.
    jaraco committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    94b6d14 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    4d50db3 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    3debdcc View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e88bd79 View commit details
    Browse the repository at this point in the history
  16. In test_convert_path, utilize posixpath.join and ntpath.join for maxi…

    …mum compatibility with other libraries.
    jaraco committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d48a881 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    8eb6b57 View commit details
    Browse the repository at this point in the history
  18. convert_path no longer fails if passed a path with a trailing slash. …

    …Instead, trailing slashes are stripped just as they are with pathlib.Path.
    
    Ref pypa/distutils#272 (comment).
    jaraco committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    4232b01 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. convert_path now converts to a platform-native path.Path, but then ca…

    …lls `.as_posix()` on it.
    
    This change will have the unintended effect of adding support for backslashes on Windows. Maybe that's fine, or maybe it should be prohibited.
    jaraco committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    b4df774 View commit details
    Browse the repository at this point in the history
  2. Separate test_convert_path into two tests to avoid interactions in mo…

    …nkeypatching os.path.
    jaraco committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    c67da35 View commit details
    Browse the repository at this point in the history
  3. Remove expectation that a ValueError is raised for data_files being d…

    …rive-relative absolute on Windows.
    jaraco committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    1e97e21 View commit details
    Browse the repository at this point in the history
  4. Simplify convert_path by simply relying on the logic in PurePath.

    Test for convert_path no longer runs on all operating systems as it's too difficult (impossible) to monkeypatch PurePath reliably.
    jaraco committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    4b3f16f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c4d3c3c View commit details
    Browse the repository at this point in the history
  6. Consolidate convert_path tests and just generate the expected value i…

    …n a platform-sensitive way. Should fix failures on mingw.
    jaraco committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    a166815 View commit details
    Browse the repository at this point in the history
  7. Merge pull request pypa/distutils#272 from pypa/feature/pathlib-data-…

    …files
    
    Allow path objects for data-files
    jaraco committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    01f9af2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c9ec8f8 View commit details
    Browse the repository at this point in the history
  9. Use simple import

    jaraco committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    a74d289 View commit details
    Browse the repository at this point in the history
  10. Merge pull request pypa/distutils#237 from pypa/pathlike_ext

    ENH: Extension should be able to accept PathLike sources objects
    jaraco committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    e1e9f61 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. venv_install_options: add missing clear_argv fixture

    Otherwise the test fails if arguments are passed to pytest, for example --no-cov:
    
    FAILED distutils/tests/test_dist.py::TestDistributionBehavior::test_venv_install_options -
          distutils.errors.DistutilsArgError: option --no-cov not recognized
    lazka committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    cf47197 View commit details
    Browse the repository at this point in the history
  2. CI: add a job for running tests under MSVC CPython with GCC as the de…

    …fault compiler
    
    The tests currently assume everywhere that there is only one compiler per platform,
    and while it would be possible to parametrize all the tests it would make things more
    complex and we'd also have to decide which compiler is required for running the tests and
    which one is optional etc.
    
    To avoid all this introduce a DISTUTILS_TEST_DEFAULT_COMPILER env var which can be used
    to override the default compiler type for the whole test run. This keeps the tests as is
    and makes sure all tests run against the alternative compiler. Also add it to pass_env
    for tox, so it gets passed to pytest, if set.
    
    The added CI job installs an ucrt targeting GCC via MSYS2, and forces the MSVC CPython
    to use it via DISTUTILS_TEST_DEFAULT_COMPILER=mingw32.
    lazka committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    6a39d04 View commit details
    Browse the repository at this point in the history
  3. mingw: make get_msvcr() a noop

    This was added back in the day to make mingw use the same CRT as CPython
    (https://bugs.python.org/issue870382), but at least with newer mingw-w64 and
    ucrt switching the CRT at "runtime" isn't supported anymore. To build a
    compatible extension you have to use a ucrt mingw-w64 build, so things match
    up and link against the same CRT.
    
    CPython 3.5+ uses ucrt (see https://wiki.python.org/moin/WindowsCompilers), so
    anything besides that is no longer relevant, which only leaves vcruntime140.
    
    Since it's not clear what linking against vcruntime140 solves, and there have
    been reports of it needing to be patched out:
    
    * #4101
    * pypa/distutils#204 (comment)
    
    let's just make it return nothing. Keep get_msvcr() around for now to avoid breaking
    code which patched it.
    
    Fixes #204
    lazka committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    943fc82 View commit details
    Browse the repository at this point in the history
  4. Remove unused RangeMap

    Its last use in cygwinccompiler was just removed.
    lazka committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    267fb5f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    93ab2a5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    95088c5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    edc3808 View commit details
    Browse the repository at this point in the history
  4. Refactored customize_compiler to reduce logical branches and extract …

    …_add_flags logic.
    
    Reduces cyclomatic complexity so it passes QA checks.
    jaraco committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3e4b457 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fcef963 View commit details
    Browse the repository at this point in the history
  6. Merge pull request pypa/distutils#228 from pypa/feature/cpp-support

    Distutils C++ support
    jaraco committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3e11381 View commit details
    Browse the repository at this point in the history
  7. Merge pull request pypa/distutils#273 from msys2-contrib/tests-fix-ve…

    …nv_install_options
    
    venv_install_options: add missing clear_argv fixture
    jaraco committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ab3f84e View commit details
    Browse the repository at this point in the history
  8. Merge pull request pypa/distutils#274 from msys2-contrib/ci-msvc-pyth…

    …on-mingw-variant2
    
    mingw: make get_msvcr() a noop + add a CI job testing MSVC Python with GCC
    jaraco committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    de4e1be View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c9781ae View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d7ffdb9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c22938c View commit details
    Browse the repository at this point in the history
  12. Add news fragment.

    jaraco committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3fc3c6f View commit details
    Browse the repository at this point in the history