"Embed" test_bdist_wheel files and execution #4429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Currently
test_bdist_wheel
:setuptools/tests/bdist_wheel_testdata
:MANIFEST.in
and is error prone (see [BUG] Test data missing (extension.c
files and more) missing in 70.1.0 sdist #4428).Some files are missing in the
sdist
and others may be erroneously added depending on how clean your directory is (e.g.setuptools/tests/bdist_wheel_testdata/*/build
).This affects setuptools a lot because we cannot use
setuptools-scm
, but even if we could it also complicates "git" management itself...I found a couple of files that should not have been committed (e.g.
.so
files that were generated by tests).python setup.py bdist_wheel
via subprocess:setup.py
) is that it complicates collecting coverage data.This PR "embeds" both of these aspects:
bdist_wheel
command runs via API in the current process.Closes #4428
Pull Request Checklist
newsfragments/
.(See documentation for details)