Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __pycache__/ to .gitignore #4325

Closed
wants to merge 1 commit into from
Closed

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Apr 24, 2024

Summary of changes

Running tox locally leaves a lot of files behind in __pycache__ folders.
image
This PR adds the cache folder to the .gitignore, since this is specific to this project (using tox) and not my personal environment.

Pull Request Checklist

@abravalheri
Copy link
Contributor

https://blog.jaraco.com/skeleton/#ignoring-artifacts does mention __pycache__ in the suggested .gitignore_global, so by that logic, this line would not be necessary...

However there is precedent (the currently ignored *.pyc, .mypy_cache, .pytest_cache, etc...). So I will defer this one to Jason 😅.

@Avasam
Copy link
Contributor Author

Avasam commented Jun 12, 2024

CC @jaraco

@Avasam Avasam force-pushed the pycache-gitignore branch from 1363ceb to d5b09aa Compare July 1, 2024 16:10
@jaraco
Copy link
Member

jaraco commented Jul 1, 2024

My preference would be to eliminate non-project-specific ignores from the .gitignore (and the toil that comes with maintaining such a file across the multitudes of projects that exist). I'm pretty sure none of those exclusions currently in the .gitignore are both specific to setuptools and not covered by the recommended config.

What do you think about instead trying to adopt that approach? I think you'll find it's much nicer for everyone involved. I'll update it to link to my latest config.

@jaraco jaraco mentioned this pull request Jul 1, 2024
@jaraco
Copy link
Member

jaraco commented Jul 2, 2024

We're almost certainly going to decline this change in favor of #4453. Thanks for the suggestion regardless.

@jaraco jaraco closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants