Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cygwin for now #3923

Merged
merged 1 commit into from
May 11, 2023
Merged

Disable cygwin for now #3923

merged 1 commit into from
May 11, 2023

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented May 11, 2023

Workaround for #3921.

CC @lazka : Would you be willing to look into what it will take to make a rust compiler available in the test_cygwin?

@abravalheri
Copy link
Contributor

abravalheri commented May 11, 2023

@jaraco, how about we use something like the following in setup.cfg:

[options.extras_require]
testing =
   # ...
   pytest-ruff; sys_platform != "cygwin"

(i.e. instead of disabling the whole cygwin test, we rely on pytest-enabler not finding it installed and skipping the pytest plugin, but still running the majority of tests).

Would that be a valid workaround?

@jaraco
Copy link
Member Author

jaraco commented May 11, 2023

Good idea. It's still not a precise match, because in theory it should work, but definitely a superior approach.

@jaraco jaraco merged commit e76db44 into main May 11, 2023
@jaraco jaraco deleted the debt/disable-cygwin branch May 11, 2023 23:50
@lazka
Copy link
Contributor

lazka commented May 11, 2023

(Rust doesn't support cygwin, so that's unlikely to work)

@DWesl
Copy link
Contributor

DWesl commented May 13, 2023

what it will take to make a rust compiler available in the test_cygwin?

Add Cygwin as a target to the rust codebase, create a cross-compiler on an existing target, then use that to create a native compiler
rust-lang/rust#79854 (comment)

Alternately, try to get mrustc working on Cygwin
https://github.com/thepowersgang/mrustc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants