Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only import ctypes when necessary #3178

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Only import ctypes when necessary #3178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a48561e
Only import ctypes when necessary
radarhere Mar 19, 2022
b777ab4
Add news fragment
abravalheri Mar 23, 2022
5fd0ccf
Fixed typo
radarhere Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.d/3178.change.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Postponed importing ``ctypes`` when hiding files on Windows.
This helps to prevent errors in systems that might not have `libffi` installed.
2 changes: 1 addition & 1 deletion setuptools/windows_support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import platform
import ctypes


def windows_only(func):
Expand All @@ -17,6 +16,7 @@ def hide_file(path):

`path` must be text.
"""
import ctypes
__import__('ctypes.wintypes')
SetFileAttributes = ctypes.windll.kernel32.SetFileAttributesW
SetFileAttributes.argtypes = ctypes.wintypes.LPWSTR, ctypes.wintypes.DWORD
Expand Down