Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests capturing expected distutils behavior. #2315

Merged
merged 4 commits into from
Aug 8, 2020
Merged

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Aug 8, 2020

Add three tests to capture the expected and anticipated behavior for distutils adoption.

Ref #417

@jaraco
Copy link
Member Author

jaraco commented Aug 8, 2020

The tests are failing on Windows presumably due to a bug in pytest-virtualenv or subprocess where virtualenv.run(['pip']) or virtualenv.run(['python']) doesn't execute in the virtualenv.

@jaraco
Copy link
Member Author

jaraco commented Aug 8, 2020

While working on a test to capture the failure on Windows, I run into another failure on pytest-virtualenv.

@jaraco
Copy link
Member Author

jaraco commented Aug 8, 2020

The test is failing due to man-group/pytest-plugins#166. I think probably I'll need to find another library to support virtualenv-based testing reliably.

…araco.envs.VirtualEnv and build a bespoke fixture with a run command.
@jaraco
Copy link
Member Author

jaraco commented Aug 8, 2020

Hmm. Now there are new errors when executing on Windows:

Fatal Python error: _Py_HashRandomization_Init: failed to get random numbers to initialize Python
Python runtime state: preinitialized

WTH?

@pganssle
Copy link
Member

pganssle commented Aug 8, 2020

I'm wondering if it might be easier to get "test as installed" working for at least a subset of the tests?

Thanks for all this effort. I'd try to help but the power at my house has been out since Tuesday (and I'm at an out of town event today).

@jaraco
Copy link
Member Author

jaraco commented Aug 8, 2020

Some searching led me to others who've had the problem. It seems that SYSTEMROOT must be set in the environment or Python will fail to start.

@jaraco
Copy link
Member Author

jaraco commented Aug 8, 2020

If with the SYSTEMROOT fix, the tests are still failing for me locally on Windows (in particular, test_distutils_local_with_setuptools). I'm trying to figure out why.

@jaraco jaraco force-pushed the feature/417-tests branch 2 times, most recently from f9fd812 to 177cd6d Compare August 8, 2020 22:00
@jaraco jaraco merged commit 59e116c into master Aug 8, 2020
@jaraco jaraco deleted the feature/417-tests branch August 8, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants