Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev script to update vendors #2179

Closed
wants to merge 1 commit into from

Conversation

ozars
Copy link
Contributor

@ozars ozars commented Jun 4, 2020

Summary of changes

A script updating vendors is added. It checks diff of vendored.txt against HEAD, creates a patch against existing version, downloads and copies new version and applies the patch (if not empty).

There are some more work to trigger CI automatically as described in #1696 if needed, however, it should take care of the first task described there.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details

@benoit-pierre
Copy link
Member

Isn't that what's already available through one of the pavement.py task (paver update_vendored)?

@ozars
Copy link
Contributor Author

ozars commented Jun 4, 2020

Oh well that's really embrassing. Yeah, apparently I missed that last part in the developer guide and duplicated the entire thing unaware of it. Closing this.

@ozars ozars closed this Jun 4, 2020
@pganssle
Copy link
Member

pganssle commented Jun 4, 2020

It might still be valuable to add a tox environment that runs paver, since I think paver requires installing some dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants