Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep425tags: don't append 'm' to ABI tag in Python 3.8 #1822

Closed
wants to merge 1 commit into from
Closed

pep425tags: don't append 'm' to ABI tag in Python 3.8 #1822

wants to merge 1 commit into from

Conversation

rdb
Copy link

@rdb rdb commented Aug 17, 2019

This makes changes to the pep425tags module following changes made in pip and wheel:
pypa/pip#6874
pypa/wheel#303

It fixes the get_abi_tag() function, which appended a m flag to the ABI tag on Windows despite this tag no longer existing in Python 3.8. For more info see:
https://bugs.python.org/issue36707
https://docs.python.org/dev/whatsnew/3.8.html#build-and-c-api-changes

I'm not actually sure whether this function is used anywhere important; my testing was around building and installing wheels and this change didn't seem to be needed, but it is nonetheless good to ensure that the function does the right thing as long as it is there. As such, I am not sure whether it is critical to get this change into the ensurepip shipped with Python 3.8.

@benoit-pierre
Copy link
Member

Thanks, but if we were to backport some fixes in our copy of pep425tags, than it should be done by updating the whole files (including tests and glibc related changes), since it's better in the long term (we don't want to deviate from pip's versions of those).

But since packaging now has a dedicated module for handling PEP 425, I think switching to that is an even better long term solution, see #1829.

@jaraco
Copy link
Member

jaraco commented May 24, 2020

Agreed with Benoit. Let's rely on shared libraries where possible.

Thanks for the contrib. This approach was clean and acceptable otherwise and served as a good inspiration to develop a more robust solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants