-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError in sandbox tests #860
Comments
I'm able to replicate the failures locally, but not against v28.8.0, so it appears to be a regression with some commit preceding the release of v28.9.0. The failure doesn't occur if I run tests with |
Well, I was able to replicate it locally, but now I'm not, even against master, and even when I run the whole test suite. I'm not sure what's going on. |
Running the test now, I'm getting the failure again. I think perhaps I hadn't properly gotten back to master. I can replicate the test failure running only the tests from two files:
|
When it fails, there's a pseudo module in
|
It appears to me that code is being injected by pytest here. It seems that code has been around a long time, so it's only now that it's been triggered, presumably by something in the new test_namespaces.py. |
If I remove the pytest skip, the issue doesn't occur.
|
That explains why the tests started failing recently -- that behavior was added in e8d53c0. |
Bypassing the string-style expression in the skip condition bypasses the issue, now reported upstream. |
About a week ago, tests started failing like so with errors in hide_setuptools when module names are 'None'.
The text was updated successfully, but these errors were encountered: