Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an UTF8 enabled locale for the run() environment. #900

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

arvidma
Copy link
Contributor

@arvidma arvidma commented Sep 13, 2023

I have not managed to make a unit test that recreates the problem. While failing with that, I think I have narrowed down the true origin of the problem:

It is not mercurial having trouble with LC_ALL=C. It is Python itself that fails during start-up, when it encounters a pth-file in site-packages, that has a non-ascii character inside of it. This in turn only happens when I initiate the pip wheel command while my virtualenv (with an editable install of the project) is active.

In order to make a test for this, one would need to prep the test by installing an (in)appropriate package in the test environment. I do not want to take on that type of effort, so I'll just leave this one-liner here for you to accept or reject!

With my findning on the core of the problem, I have a solid work-around available (just don't run pip wheel with an active virtualenv), so I don't feel very strongly about the issue any more.

Kind regards,
Arvid

Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this,
lets add a comment to mention python using ascii without the utf-8 + add a changelog entry on the bugfix to complete it

test in this case is nice to have but not critical

@RonnyPfannschmidt
Copy link
Contributor

thanks 🤟

@RonnyPfannschmidt RonnyPfannschmidt merged commit 2e5c2f8 into pypa:main Sep 13, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants