Normalize the dist-name, as per PEP503, when looking for overrides #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
requested changes
May 17, 2023
…n environment variables for overrides. Closes pypa#829.
pelson
force-pushed
the
fix/normalize_override_env_name
branch
from
a440306
to
28c8d52
Compare
RonnyPfannschmidt
approved these changes
May 19, 2023
|
thanks! |
Glad we could ship it! Thanks for the quick response and positive experience! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #829.
It is worth noting that technically this is a breaking change. I didn't aim for backwards compat, as I figured the behaviour was pretty inconvenient/unfriendly, as per the original issue.