Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hg: use same logic as git for finding latest tagged commit #236

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

avirshup
Copy link
Contributor

This is a fix for #229

@avirshup avirshup changed the title hg: use same logic as git for finding latest commit hg: use same logic as git for finding latest tagged commit Mar 22, 2018
@avirshup
Copy link
Contributor Author

avirshup commented Apr 2, 2018

This PR ignores hg tags that don't contain a '.' in them (similarly to the way git.py uses git describe).

I've created a couple new helper functions in hg.py to do this -

  • get_graph_distance for computing the distance between two revisions in mercurial, and
  • get_latest_normalizable_tag, for returning the latest "version-like" hg tag. Right now, it just inelegantly filters for the presence of '.' in the tag. But it will likely be rewritten by a more general test in the fix for git and hg: ignore tags that can't be normalized to version numbers #235.

@RonnyPfannschmidt
Copy link
Contributor

sorry for the delay, i have been on travel and didnt get to sorting it before, i plan to sort the backlog on setuptools_scm until the weekend, thanks for the patience

@RonnyPfannschmidt RonnyPfannschmidt merged commit 366e658 into pypa:master Apr 6, 2018
@RonnyPfannschmidt
Copy link
Contributor

thanks 👍

@avirshup
Copy link
Contributor Author

avirshup commented Apr 6, 2018

Thanks - and no worries whatsoever about the timing, open source maintainers deserve vacations too :)

@RonnyPfannschmidt
Copy link
Contributor

i plan to do a release with support for branches added and support for ancient broken setuptools dropped, please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants