Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to pygments 2.14.0 #272

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Adapt tests to pygments 2.14.0 #272

merged 1 commit into from
Jan 5, 2023

Conversation

danigm
Copy link
Contributor

@danigm danigm commented Jan 4, 2023

This patch update the test fixtures to match the output of pygments 2.14.0

This patch update the test fixtures to match the output of pygments
2.14.0
@miketheman
Copy link
Member

Thanks @danigm ! I'm curious - how did this surface, and do you happen to know what changed in Pygments that caused this change in the output?

@danigm
Copy link
Contributor Author

danigm commented Jan 5, 2023

Thanks @danigm ! I'm curious - how did this surface, and do you happen to know what changed in Pygments that caused this change in the output?

I found the problem after fixing a similar issue in pytest: pytest-dev/pytest#10630

What I've done to change the output is compare what the test output is expecting and modifying the fixtures until all tests are correct, but you can check the pygments commit and see all the changes in test files, that are very similar to this one.

@di di merged commit db67d96 into pypa:main Jan 5, 2023
@di
Copy link
Member

di commented Jan 5, 2023

Thanks!

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 15, 2023
https://build.opensuse.org/request/show/1055954
by user dgarcia + dimstar_suse
- Add fix-tests-pygments-2.14.0.patch to adapt tests to the new version of
  pygments gh#pypa/readme_renderer#272
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Sep 8, 2023
https://build.opensuse.org/request/show/1109530
by user dirkmueller + anag+factory
- update to 41.0:
  * Allow HTML5 `figcaption` tag through cleaner (#291)
  * Test `README.rst` from this project (#288)
  * Add CLI option to render package README. (#271)
  * Adapt tests to pygments 2.14.0 (#272)
  * Update release process to use Trusted Publishing (#276)
  * Replace usage of deprecated `pkg_resources` with
    `importlib.metadata` (#281)
  * Drop support for Python 3.7 (#282), Test against Python 3.11
    (#280)
- drop fix-tests-pygments-2.14.0.patch (upstream)

  pygments gh#pypa/readme_renderer#272
 * Preserve lang attribute in pre (#247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants