Whitelist the allowed CSS classes #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstufft
commented
Sep 18, 2018
| @@ -54,21 +56,75 @@ | |||
| "width", "height", | |||
| ] | |||
|
|
|||
| ALLOWED_CLASSES = { | |||
| "img": ["align-left", "align-center", "align-right"], | |||
| "span": [c for c in pygments.token.STANDARD_TYPES.values() if c], | |||
There was a problem hiding this comment.
Two things:
- I'm not sure if there is any use of a class inside of a span that isn't there to enable pygments, or if the list of pygments classes is all we need to worry about here.
- @theacodes has set the
<code>element to allow classes in the PR that added syntax highlighting, but I can't determine what classes are valid for the<code>element. Trying different combinations of things doesn't seem to actually generate code that emits a class on the<code>element. If we can't figure out how to make a README emit a<code>element with css classes, we should probably emitclassfrom<code>.
There was a problem hiding this comment.
Are you trying just with RST? I think I added it for Markdown, not sure though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent people from being able to apply classes to their rendered text that we did not otherwise want to allow them to do. For instance they won't be able to apply the same CSS class to their image that our logo uses, which would theoretically let them replace our logo.