Merge pull request #121 from mila/112-inline-styles

Do not allow inline styles
pypa · Sep 18, 2018 · 5d80e46 · 5d80e46
2 parents 12d6bd0 + e644d14
commit 5d80e46
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 8 deletions.
diff --git a/readme_renderer/clean.py b/readme_renderer/clean.py
@@ -42,7 +42,7 @@
     # Custom Additions
     "*": ["id"],
     "hr": ["class"],
-    "img": ["src", "width", "height", "alt", "align", "class", "style"],
+    "img": ["src", "width", "height", "alt", "align", "class"],
     "span": ["class"],
     "th": ["align"],
     "td": ["align"],
@@ -51,7 +51,6 @@
 }
 
 ALLOWED_STYLES = [
-    "width", "height",
 ]
 
 

diff --git a/tests/fixtures/test_CommonMark_style.html b/tests/fixtures/test_CommonMark_style.html
@@ -1 +1 @@
-<img src="https://example.com/badge.png" style="width: 20px; height: 20px;">
+<img src="https://example.com/badge.png">
diff --git a/tests/fixtures/test_CommonMark_style.md b/tests/fixtures/test_CommonMark_style.md
@@ -1 +1 @@
-<img src="https://example.com/badge.png" style="width: 20px; height: 20px; color:red;">
+<img src="https://example.com/badge.png">
diff --git a/tests/fixtures/test_GFM_style.html b/tests/fixtures/test_GFM_style.html
@@ -1 +1 @@
-<img src="https://example.com/badge.png" style="width: 20px; height: 20px;">
+<img src="https://example.com/badge.png">
diff --git a/tests/fixtures/test_GFM_style.md b/tests/fixtures/test_GFM_style.md
@@ -1 +1 @@
-<img src="https://example.com/badge.png" style="width: 20px; height: 20px; color:red;">
+<img src="https://example.com/badge.png">
diff --git a/tests/fixtures/test_rst_png_attrs.html b/tests/fixtures/test_rst_png_attrs.html
@@ -1 +1 @@
-<img alt="alternate text" class="align-right" src="https://example.com/badge.png" style="width: 25.0%; height: 100px;">
+<img alt="alternate text" class="align-right" src="https://example.com/badge.png">
diff --git a/tests/fixtures/test_rst_svg_attrs.html b/tests/fixtures/test_rst_svg_attrs.html
@@ -1 +1 @@
-<img alt="alternate text" class="align-right" src="https://example.com/badge.svg" style="width: 25.0%; height: 100px;">
+<img alt="alternate text" class="align-right" src="https://example.com/badge.svg">
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<img src="https://example.com/badge.png" style="width: 20px; height: 20px;">
		<img src="https://example.com/badge.png">
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<img alt="alternate text" class="align-right" src="https://example.com/badge.png" style="width: 25.0%; height: 100px;">
		<img alt="alternate text" class="align-right" src="https://example.com/badge.png">