fix: require version in dynamic if unset #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/fix/require-version
branch
from
cff7e55
to
01adb12
Compare
henryiii
force-pushed
the
henryiii/fix/require-version
branch
2 times, most recently
from
1904306
to
df0f3e3
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/require-version
branch
from
df0f3e3
to
581a309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #67.
Will followup later, but this should fix the problem above.
I think the long term fix that would allow the rest of the fields might be as follows: add a new field
_value_added. Whenever a user sets a value,value_addedrecords it. Then we can computeset(dynamic) - set(value_added)and if anything is left, that's Metadata 2.2 dynamic. This feels safer than modifing the dynamic field.