feat(types): Add TypedDict #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
reviewed
Aug 10, 2024
frostming
reviewed
Aug 10, 2024
|
PS: I have some ideas to refactor DataFetcher to avoid killing static types (which didn't matter before, as there weren't any). I'll try those out in a few days (traveling for a meeting). |
henryiii
force-pushed
the
henryiii/feat/typeddict
branch
2 times, most recently
from
a35d9dd
to
6de822d
Compare
frostming
approved these changes
Sep 13, 2024
henryiii
force-pushed
the
henryiii/feat/typeddict
branch
3 times, most recently
from
59825e2
to
7c33895
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> fix: more precise, better runtime support Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/feat/typeddict
branch
from
7c33895
to
304468c
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial attempt to add a TypedDict for the pyproject.toml input. Unfortunately, DataFetcher kills all internal static type info so this isn't checked. Working on this primarily for pypa/packaging#647.