Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the high level interface #108

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

hexagonrecursion
Copy link
Contributor

#91

Add a deprecation warning when pep517.build is used
Add a deprecation warning when pep517.checkis used

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I don't think these should be print statements, but rather log.warning(...) calls inside the main function. That'll allow downstream users to use all of logging's capabilities to handle and manage these logs.

pep517/check.py Outdated Show resolved Hide resolved
@hexagonrecursion
Copy link
Contributor Author

Thanks for the PR!

I don't think these should be print statements, but rather log.warning(...) calls inside the main function. That'll allow downstream users to use all of logging's capabilities to handle and manage these logs.

Should I put log.warning in main() or at the top of the module after the imports?

@hexagonrecursion
Copy link
Contributor Author

Done

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

pep517/build.py Outdated Show resolved Hide resolved
@hexagonrecursion
Copy link
Contributor Author

done

@pradyunsg pradyunsg merged commit e027d98 into pypa:master Feb 2, 2021
@hexagonrecursion hexagonrecursion deleted the deprecate branch February 2, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants