-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the high level interface #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I don't think these should be print statements, but rather log.warning(...) calls inside the main function. That'll allow downstream users to use all of logging's capabilities to handle and manage these logs.
Should I put log.warning in main() or at the top of the module after the imports? |
03e06b0
to
ae81d5f
Compare
Done |
ae81d5f
to
0271c38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
0271c38
to
cfb143d
Compare
done |
#91