Use creator venv when creating virtual environments #5376
Conversation
matteius
changed the title
| @@ -903,6 +903,7 @@ def do_create_virtualenv(project, python=None, site_packages=None, pypi_mirror=N | |||
| Path(sys.executable).absolute().as_posix(), | |||
| "-m", | |||
| "virtualenv", | |||
| "--creator=venv", | |||
There was a problem hiding this comment.
Can we simplify this to: -m venv I hope we are not using any specific features of virtualenv which aren't found in venv.
There was a problem hiding this comment.
I believe that Ubuntu does not ship venv as part of the system python so this might not solve the issue...
There was a problem hiding this comment.
This change did solve the issue for my ubuntu 22.04 -- I am not sure if that -m venv is equivalent to this, do you know?
There was a problem hiding this comment.
The built in module venv is a trimmed down version of virtualenv: https://virtualenv.pypa.io/en/latest/.
We can't use this approach immediately anyway because it only supports one python version.
To use this approach, we will have to detect the python version by ourselves. That's because you can only do:
python3.X -m venv ...
Instead of:
python -m virtualenv --python ....
| @@ -903,6 +903,7 @@ def do_create_virtualenv(project, python=None, site_packages=None, pypi_mirror=N | |||
| Path(sys.executable).absolute().as_posix(), | |||
| "-m", | |||
| "virtualenv", | |||
| "--creator=venv", | |||
There was a problem hiding this comment.
The built in module venv is a trimmed down version of virtualenv: https://virtualenv.pypa.io/en/latest/.
We can't use this approach immediately anyway because it only supports one python version.
To use this approach, we will have to detect the python version by ourselves. That's because you can only do:
python3.X -m venv ...
Instead of:
python -m virtualenv --python ....
I did not realize how broken pipenv is out of the box on the latest ubuntu until I upgraded. It has to do with it defaulting to
posix_localwhen creating a virtualenv, which has different paths for the python binaries. I initially tried preferringposix_localfor the paths but it had the side effect of trying to install everything to local site packages.Risks: The venv creator should be available on all systems, but the documentation points out: