Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4993 Add standard pre commit hooks and apply linting. #4994

Merged
merged 21 commits into from
Mar 30, 2022
Merged

Issue 4993 Add standard pre commit hooks and apply linting. #4994

merged 21 commits into from
Mar 30, 2022

Commits on Mar 17, 2022

  1. Replace all git:// protocol with https:// to fix the failing git prot… 

    …ocol tests.
    @matteius
    matteius committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    893bb0b View commit details
    Browse the repository at this point in the history

  2. Split apart the massive utils.py

    @matteius
    matteius committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    5ba8689 View commit details
    Browse the repository at this point in the history

  3. Sorting out remaining import errors with new utils module

    @matteius
    matteius committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    bfc810e View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. * Kill off more unused utilities and relocate private method _show_wa… 

    …rning to above its usage.

* Move these utils from internet since they are shell related and remove rm_tree as it pipenv uses the version from vistir.
    @matteius
    matteius committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    3770457 View commit details
    Browse the repository at this point in the history

  2. Add news fragment.

    @matteius
    matteius committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    f6481f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2022

  1. Add .pre-commit-config.yaml to the project and exclude tests (for now… 

    …). This does not include the MyPy linting that pip does but does include everything else.
    @matteius
    matteius committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    1956c61 View commit details
    Browse the repository at this point in the history

  2. Major part of the linting applied but had to commnet out parts of the… 

    … configuration to be able to commit this.
    @matteius
    matteius committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    81d93ef View commit details
    Browse the repository at this point in the history

  3. isort working and black compatability issues sorted--finish applying 

    linting.
    @matteius
    matteius committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    ee27bd7 View commit details
    Browse the repository at this point in the history

  4. Add pre-commit requirements, and update to the CI runner the lint che… 

    …ck of the project.

Undoes backtick changes to vendor files.
    @matteius
    matteius committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    9500e85 View commit details
    Browse the repository at this point in the history

  5. Enable the pygrep-hooks and fix rst-backticks

    @matteius
    matteius committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    c1045ba View commit details
    Browse the repository at this point in the history

  6. Ensure towncrier news templates are correctly named. Add news fragmen… 

    …t for the linting changes.
    @matteius
    matteius committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    ffef3c3 View commit details
    Browse the repository at this point in the history

  7. Add notes about pre-commit hooks to the contributing .rst

    @matteius
    matteius committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    d3d11f5 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into code-reorg-utils-reduces-complexity

    @matteius
    matteius committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    e75ba0b View commit details
    Browse the repository at this point in the history

  9. Merge branch 'code-reorg-utils-reduces-complexity' into issue-4993-pr… 

    …e-commit-hooks
    @matteius
    matteius committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    d41d86c View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2022

  1. spotted this method regression in downstream refactor branch.

    @matteius
    matteius committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    fc7fdb5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'code-reorg-utils-reduces-complexity' into issue-4993-pr… 

    …e-commit-hooks
    @matteius
    matteius committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    6038ff3 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. backport changes from utils.py to the utils module

    @matteius
    matteius committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    a1c1bb2 View commit details
    Browse the repository at this point in the history

  2. merge main into reorg utils branch.

    @matteius
    matteius committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    0ba6dc4 View commit details
    Browse the repository at this point in the history

  3. Resolve merge conflict with upstream.

    @matteius
    matteius committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    34bb52e View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. merge main into linting branch

    @matteius
    matteius committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    7680910 View commit details
    Browse the repository at this point in the history

  2. Update black to be compatible with new click version.

    @matteius
    matteius committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    f4435c6 View commit details
    Browse the repository at this point in the history