Fix compatibility with click version 8 #4726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new version of click, if an option has no type and a default value is of type bool, the default type is bool and the required value for the option is also bool which is not correct for options like --code, --requirements, or --python.
Click 7:
Click 8:
As you can see above, the new behavior is not a problem for some of the options because --index and --editable have a specific type, --extra-index-url has a string as a default value, etc.
This change should not affect pipenv in any way and should make it more compatible with the new version of click which pipenv surely vendor soon.
Also, explicit is better than implicit 😃