Proper case windows #3105
Merged
Proper case windows #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
force-pushed
the
proper-case-windows
branch
from
9a690af
to
bb85253
Compare
techalchemy
reviewed
Oct 29, 2018
|
hmm is this already fixed in #3096 ? |
|
@techalchemy No, I reproduced the bug with the pipenv@update-vendor branch. |
|
ok this makes sense, confirmed it locally too, thanks for the fix! |
techalchemy
added
OS: Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
The issue
pipenv cleanwill fail to detect the unnecessary packages because the path is not cased properly.The fix
Make
_normalizealways return the real cased path on Windows. Fixes #3104The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.