Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call virtualenv by module #2198

Merged
merged 3 commits into from
May 16, 2018
Merged

Call virtualenv by module #2198

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55d77b2
Call virtualenv by module instead of command
uranusjr May 15, 2018
904f7d6
Merge branch 'master' into call-virtualenv-by-module
techalchemy May 15, 2018
ee36c6a
Merge branch 'master' into call-virtualenv-by-module
techalchemy May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pipenv/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,7 @@ def do_create_virtualenv(python=None, site_packages=False):
# The user wants the virtualenv in the project.
if project.is_venv_in_project():
cmd = [
'virtualenv',
sys.executable, '-m', 'virtualenv',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to use which('virtualenv') and fallback to sys.executable in case we can't find virtualenv or something, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what the merit is. Is it so the user can set virtualenv to, like, a “better virtualenv”? Using our own dependency (even if not vendored) feels a much safer, predictable solution to me. Also in practice virtualenv hasn’t been updated in almost two years (last in November 2016), so the extra which check is more than likely just wasted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i thought about it more and this does guarantee that we get the one that got installed with pipenv, so I like this

project.virtualenv_location,
'--prompt=({0})'.format(project.name),
]
Expand Down